Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sprint and noslotset are always active regardless of being enabled #2580

Closed
182exe opened this issue Mar 24, 2024 · 25 comments
Closed
Labels
🐛 bug Something isn't working 🌕 legacy
Milestone

Comments

@182exe
Copy link

182exe commented Mar 24, 2024

LiquidBounce Branch

Legacy

LiquidBounce Build/Version

latest build

Operating System

Windows 11

Minecraft Version

1.8.9

Describe the bug

Sprint:
If the alldirections sprint is enabled and onholdkey is also enabled, then if the sprint module is enabled or disabled you can still sprint in all directions.

Noslotset:
On Minemen specifically, sometimes when winning or losing a game and getting sent back to the lobby your client sided slot will differ from the server sided slot and right or left clicking without first using the scroll wheel to reset your slot again will get you banned. I'm not sure if this is just a Minemen thing.

Steps to reproduce

Sprint:

  1. Enable sprint
  2. Enable alldirections and onkeyhold
  3. Disable sprint
  4. Try holding your sprint key and running backwards.

Noslotset:

  1. Not entirely sure, try just playing on minemen, losing a game and before you get sent back to the lobby set your slot to like 6 or something and wait for yourself to get sent back to spawn.

Client Log

ask if needed

Screenshots

No response

@github-actions github-actions bot added 🌕 legacy 🐛 bug Something isn't working labels Mar 24, 2024
@EclipsesDev
Copy link

can u provide the setting for the sprint module? cuz i cannot reproduce the same issue

@EclipsesDev
Copy link

also provide log, that would be useful

@EclipsesDev
Copy link

soo..?

@182exe
Copy link
Author

182exe commented Mar 31, 2024

8mb.video-27g-7nwIwhxV.mp4

also, the only log that wasnt just a chat message or the config saving if i changed it was this:

13:17:21.301
net.minecraft.client.renderer.WorldRenderer
Chunk Batcher 3
Needed to grow BufferBuilder buffer: Old size 524288 bytes, new size 2621440 bytes.

@EclipsesDev
Copy link

did u use autoplay?

@182exe
Copy link
Author

182exe commented Apr 1, 2024

tried checking if it was that earlier; i'm not sure if thats the reason. it happens with it enabled and its disabled.

@EclipsesDev
Copy link

@182exe try to use #2695 not sure if thats gonna fix ur issue, or causes more issue lol

@EclipsesDev
Copy link

but a yeah, try to build that using inteliJ or whatever idea u have.. 👍

@182exe
Copy link
Author

182exe commented Apr 1, 2024

i think this works...? i broke intellij on accident yesterday so i'll try again building today.
maybe another fix would be just to change client slot to server slot on world change.

@EclipsesDev
Copy link

EclipsesDev commented Apr 4, 2024

i think this works...? i broke intellij on accident yesterday so i'll try again building today. maybe another fix would be just to change client slot to server slot on world change.

yeah i was thinking about that.. idk know why i didn't do that instead..

@EclipsesDev
Copy link

actually nvm, that'll cause some server to detect badpackets (for some reason)

@EclipsesDev
Copy link

ok i think #2695 should work.. i think.. (my premium account was banned so i couldn't test it out)

@EclipsesDev
Copy link

@182exe so hows it?

@182exe
Copy link
Author

182exe commented Apr 6, 2024

i couldnt build

@EclipsesDev
Copy link

i couldnt build

hmm wait maybe cuz the version is upped, but idk.. i'll update it ig

@EclipsesDev
Copy link

Can u build? @182exe, if not maybe i could merge it (for testing)

@182exe
Copy link
Author

182exe commented Apr 12, 2024

yeah, merge it i guess.

i get a lot of errors with both intellij and eclipse.

@EclipsesDev
Copy link

yeah, merge it i guess.

i get a lot of errors with both intellij and eclipse.

I've merge it, go ahead and test it.. if there's smth wrong then probably I'll be fixing it tomorrow 👌

@182exe
Copy link
Author

182exe commented Apr 12, 2024

alright
i'll do like .panic before testing n stuff

i get home in a lot of hours, so probably wait for a response

@EclipsesDev
Copy link

ok

@EclipsesDev
Copy link

btw @182exe u got discord or smth? i have special req for u

@182exe
Copy link
Author

182exe commented Apr 14, 2024

yeah, @182exe on dc
also yeah this doesnt work and it breaks cheststealer

@EclipsesDev
Copy link

Yeah I'll fix it soon

@EclipsesDev
Copy link

Go ahead and try #2814

@EclipsesDev
Copy link

should be fixed (i think)

EclipsesDev added a commit that referenced this issue Apr 20, 2024
Should fully fixed #2580

Also added server/client slot check in text (useful for developers 😀)
@EclipsesDev EclipsesDev added this to the b91 milestone Apr 20, 2024
EclipsesDev added a commit that referenced this issue May 22, 2024
- Added Backtrack "Player" Render option. (Closes: #1463)
- Fixed Sprint not resetting correctly after toggled off. (#2580)
- Fixed FlagCheck GhostBlock less false flags.
- Simplified KillAura isEnemy function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌕 legacy
Projects
None yet
Development

No branches or pull requests

2 participants