Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Add release notes section to UPGRADING document. #987

Merged
merged 4 commits into from
Apr 4, 2018

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Apr 3, 2018

Fixes #865

Note that the 0.3 section is not necessarily complete; I added stuff I could think of off the top of my head, and skimmed the closed issues on the 0.3 milestone (where I didn't find anything that seemed like it needed mentioning).

@coveralls
Copy link

coveralls commented Apr 3, 2018

Pull Request Test Coverage Report for Build 1802

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1900 unchanged lines in 35 files lost coverage.
  • Overall coverage decreased (-55.6%) to 0.0%

Files with Coverage Reduction New Missed Lines %
hil/flaskapp.py 2 100.0%
hil/commands/util.py 4 80.0%
hil/client/extensions.py 5 100.0%
hil/commands/db.py 5 100.0%
hil/dev_support.py 13 100.0%
hil/class_resolver.py 13 100.0%
hil/commands/migrate_ipmi_info.py 13 37.14%
hil/ext/auth/null.py 13 92.86%
hil/server.py 16 72.73%
hil/network_allocator.py 19 95.0%
Totals Coverage Status
Change from base Build 1798: -55.6%
Covered Lines: 0
Relevant Lines: 2573

💛 - Coveralls

Copy link
Contributor

@xuhang57 xuhang57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just a couple small comments.

Release Notes
-------------

0.3 (Upcoming)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upcoming is a bit vague to me. Maybe having an actual date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really have an actual date. it's just as soon as we are done with all our issues marked with 0.3 milestone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm just marking it this way so that it's obvious for someone reading on master that 0.3 hasn't happened yet. When we tag 0.3 we'll remove this, but we don't have a specific date for it (though it's looking like "soon").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, am working on the version PR, which is the last PR for 0.3 milestones I believe

* Validation checks for the configuration file have been added; be advised
that if there were errors in your ``hil.cfg`` that were previously
undetected you may need to fix them before the servers will start again
* The interface to the ``hil`` command line tool has changed substantially;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to have an updated doc so we can point the readers to the relevant documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, do we think just doing --help is enough to explore it? If so we could mention that. It looks like we also updated the existing docs re: CLI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just mentioning --help should be enough. We could probably, in the future, add some documentation about the CLI (even a man page for HIL man hil).

@naved001
Copy link
Contributor

naved001 commented Apr 3, 2018

Some more things that might be useful to put in the changelog.

  • All HIL APIs now have client library support.
  • Support for maintenance pool.
  • Some new APIs
    • Networking actions can now be queried to get their status.
    • List users when using database backend
  • Updated APIs
    • List networks now shows public networks to regular users.
  • Some switches now support public key authentication. See docs/network-drivers.md for details.

@zenhack
Copy link
Contributor Author

zenhack commented Apr 3, 2018

@naved001, added that list to the doc (with some slight wording changes & added references to docs).

@naved001
Copy link
Contributor

naved001 commented Apr 3, 2018

I am happy.

naved001
naved001 previously approved these changes Apr 3, 2018
Copy link
Contributor

@naved001 naved001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 typos.

modified.
* URLs for API calls are now prefixed with a version number, which for the
current (unstable) API is ``v0``; you may need to update scripts and
settings accordingly (although the HIL tools themselves should remaining
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should remain internally consistent

+++

HaaS was renamed to HIL in this release. Accordingly, there are several
changess that need to be made when upgrading:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: changess -> changes

Thanks to Naved for spotting these.
@zenhack
Copy link
Contributor Author

zenhack commented Apr 3, 2018

@Naved, fixed.

@naved001
Copy link
Contributor

naved001 commented Apr 3, 2018

not sure if we should merge it now, or after the last PR for 0.3 is merged?

@zenhack
Copy link
Contributor Author

zenhack commented Apr 3, 2018 via email

@naved001 naved001 merged commit 3f7f641 into CCI-MOC:master Apr 4, 2018
@zenhack zenhack deleted the release-notes branch July 27, 2018 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release note documenting upgrades with haas -> hil name change
4 participants