This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Split API #185
Merged
Split API #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
locally, all the APIs work. |
ianballou
reviewed
Sep 25, 2018
ims/einstein/operations.py
Outdated
| # Prepare the ceph image name to be used. | ||
| clone_ceph_name = self.__get_ceph_image_name(disk_name) | ||
| except db_exceptions.ORMException as e: | ||
| # Quick solution for returning the name |
There was a problem hiding this comment.
We can probably delete these comments. Also it seems like an ORMException will be triggered if someone tries to import a different image with the same name & project id. That seems ok to me, just want to make sure that behaviour is fine.
There was a problem hiding this comment.
@naved001 can you delete these two comments?
naved001
force-pushed
the
split-api
branch
2 times, most recently
from
89e1692
to
b2e02a9
Compare
|
@naved001 can we rebase this and see if it fixes the CI? |
* This commit mostly modifies the BMI class. * Add two methods, create_disk and delete_disk.
* Users can just provision their node with any other disk image. * Or delete the disk (which deletes the iscsi target), and the node will not boot.
…guring out the multipathing stuff
and correct node_name to disk_name -- by @ianballou
which deletes the ipxe file the mac address based bootfile. This makes things clean. Must need access to the project that has the node to run deprovision for that node.
Also reoredered the arguments such that source image name comes before the disk name.
naved001
force-pushed
the
split-api
branch
2 times, most recently
from
f81b690
to
cf063cf
Compare
* Update the setup method in most tests to create the disk and then provision. * Update snapshot call to snapshot from disk rather than node_name * Test createing disk, provision, deprovision and deletion of disk in one run since the setup is too long. * Get rid of provision and deprovision sine when testing for snapshots. * Update the parameters for snapshot command in rest call and cli.
naved001
force-pushed
the
split-api
branch
2 times, most recently
from
ece7a91
to
c512eb2
Compare
|
@ianballou this is fixed now. yay |
2 tasks
* Since that's what it does now. * Showpro will make a comeback later when the right backend code and APIs are implemented.
ianballou
reviewed
Oct 11, 2018
docs/rest_api.md
Outdated
| --- | ||
| ###create_disk: | ||
|
|
||
| This will create a disk from a source image and an iscsi target pointing to that image. |
There was a problem hiding this comment.
"and return an iscsi..."
ianballou
approved these changes
Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has changes that @ianballou made, I am closing the other PR because it's on a fork that doesn't exist anymore (since I renamed everything to m2).