-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge libphidgets branch into indigo #18
Conversation
…digets ROS package
Merge libphidgets branch into indigo
Ok, I agree it's a good idea to move libphidget out of this module. It's a (non-ROS) module on it's own.
The sane detection of libphidget should imho look like this: v4hn@98d6e8d So what's the way to go here? Create a new (proper) libphidget21 module? |
@v4hn : I fully agree that libphidget should be a system library, not a ROS package. However, if we want to release phidgets_drivers using the ROS build farm, we need libphigets as either:
The cleanest way would be (3): manually do the deb packaging for libphidgets ourselves (like @JochenSp did for libepos), then cajole the OSRF people into uploading it onto packages.ros.org. Sounds like a lot of work though (especially the cajoling part). Do you need any new features/bug fixes from more recent versions of libphidgets? If so, it would probably be easiest to get the cob people to update their libphidgets ROS package. |
As it's unlikely that libphidget (no "s", that was added by cob) will On Fri, Mar 27, 2015 at 07:20:33AM -0700, Martin Günther wrote:
I mostly wanted to point out that you now depend on an obsolete and As this project tries to provide drivers for phidgets hardware, |
referencing @ipa-fmw as someone from who seems to be responsible for the cob_extern/libphidgets module |
Very interesting points being discussed here! :-) @v4hn, the changes were made to avoid conflicts with an existing release of libphidget and be compliant with REP 136, and hence the external library had to be removed. We've got a working release which does not conflict with Given that I think @mintar summarised very well the options we have. I do agree that this repo/package is where libphidget should be, rather than I'll open an issue over at cob_extern to discuss the matter. Suggestions and contributions are more than welcome! On a side note, perhaps what the guys who released |
On Mon, Mar 30, 2015 at 03:40:36AM -0700, Murilo FM wrote:
Sure, that would be good. But as the cob package fails to comply,
You're right in that, given that cob uses catkin_package inside their CMakeLists.txt and don't install libphidget's original pc file (both violates the REP you cited), it's "correct"(actually the only way) to include their libphidget(s).
That still doesn't allow me to use a system installation of libphidget
Thanks for opening that issue!
As I don't run a debian-style distribution over here, I can't really help with a deb-package. |
Given that you are having to build the package from source anyway, I believe the best approach would be what you did in your fork (at least until we sort this out with COB). In theory, I'm hoping the guys who maintain |
On Mon, Mar 30, 2015 at 06:37:40AM -0700, Murilo FM wrote:
The problem is that my fork doesn't work with Ubuntu and COB's libphidgets at the moment,
Yes, that would be great. |
Some updates on this issue... I contacted Phidgets regarding the packaging and distribution of their library and I have been told that there are some people currently working on the packaging for Debian. I'll get in touch with them. |
A small comment on the remark that "the official way would be to use Afaik, the CMake preferred way to deal with libraries that don't provide a find script is to contribute one yourself or write a CMake Config file (or the new page) and get either of those accepted upstream. If that is not an option, then you can use An alternative might be to exploit Catkin's support for adding additional patches to the release repository to get your config file distributed with your 3rd-party pkg. I do agree though that the current pkging in |
The changes within libphidgets branch allowed the
phidgets_drivers
package to avoid downloading and installing a third party library, depending on the existinglibphidgets
package (which is released as a .deb package).