Gamestat/method 1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmacur
reviewed
Jul 31, 2024
| expect(@game_teams_data).to be_an_instance_of(GameTeam) | ||
| end | ||
|
|
||
| xit 'has attributes' do |
There was a problem hiding this comment.
Can this be unskipped now that you have the dummy stats?
There was a problem hiding this comment.
Looks like a few other things in the test would need to be adjusted a little first.
|
This is looking good. Just one small thing, I think we can un-skip the test now that the dummy stats are in.Otherwise ready to merge. |
Sgalvin36
reviewed
Jul 31, 2024
| RSpec.describe GameTeam do | ||
| before(:each) do | ||
|
|
||
| @game_teams_data = GameTeam.new({}) |
There was a problem hiding this comment.
This should be adjusted to take in one of your dummy files
|
Clean it up afterwards as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed where game-team spec test files, put them in right file, also set up dummy csv files.