-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subscription to connection errors #3
Comments
Sure I'll take a look at exposing this. I suppose the idea behind this was to reconnect without library user being aware but I suppose it would be handy for library users to know and error has occurred |
Added new observer function that allows users to be notified when WebSocket errors occur.
I've added a new |
this is pretty good, thank you another thing that would be nice to improve (that falls outside of the scope of the issue though) is for users to be able to manage reconnects better - i.e. pass reconnectionPeriodMillis either via constructor or via a setter. and say if the value is negative, no reconnection is scheduled - but the user can take their own action by adding the error listener via the api you just added |
Agreed, there are a few usability improvements that need doing like that. Early days yet. |
Implemented in release 1.0.4 |
first of all, great project. thank you for putting your time and effort into this
currently, the BittrexExchange class doesn't seem to support connection error/close listeners. hubConnection.error() is only used internally in the class and not exposed to users, and it would be very useful to have an API similar to defining a runnable in connectToWebSocket()
The text was updated successfully, but these errors were encountered: