MarketName value added if missing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bittrex side bug: MarketName is often(always?) returned as null.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
============================================
- Coverage 83.99% 83.63% -0.36%
Complexity 227 227
============================================
Files 30 30
Lines 706 709 +3
Branches 27 27
============================================
Hits 593 593
- Misses 102 105 +3
Partials 11 11
Continue to review full report at Codecov.
|
|
Can't find a way to test what I changed in order to make the codecov pass... |
|
Thanks for the PR. I've merged into develop ready for the next release. |
|
Don't worry, there are a few unit tests needing to be written for the web socket parts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bittrex side missing value: MarketName is often(always?) returned as null.