Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a websocket connection listener #13

Closed
wants to merge 5 commits into from
Closed

Added a websocket connection listener #13

wants to merge 5 commits into from

Conversation

cymp
Copy link
Contributor

@cymp cymp commented Feb 6, 2018

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #13 into master will decrease coverage by 0.24%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
- Coverage      83.4%   83.15%   -0.25%     
- Complexity      245      246       +1     
============================================
  Files            31       31              
  Lines           741      748       +7     
  Branches         28       28              
============================================
+ Hits            618      622       +4     
- Misses          112      115       +3     
  Partials         11       11
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/ccob/bittrex4j/BittrexExchange.java 76.61% <57.14%> (-0.51%) 53 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c6b16...5b4df0b. Read the comment docs.

@cymp
Copy link
Contributor Author

cymp commented Feb 6, 2018

I just added a listener, no unit test that needs to be implemented here again.

@CCob CCob changed the base branch from master to develop February 6, 2018 16:41
@CCob
Copy link
Owner

CCob commented Feb 6, 2018

Great. Thanks for the PR. I released 1.0.5 a few days ago which contained your last PR's. I'll pull this into develop for now.

@CCob CCob closed this Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants