Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State change provides the old state as well #15

Merged
merged 7 commits into from
Feb 7, 2018
Merged

State change provides the old state as well #15

merged 7 commits into from
Feb 7, 2018

Conversation

cymp
Copy link
Contributor

@cymp cymp commented Feb 7, 2018

No description provided.

@cymp cymp changed the title code review State change provides the old state as well Feb 7, 2018
@CCob CCob changed the base branch from master to develop February 7, 2018 12:13
@cymp
Copy link
Contributor Author

cymp commented Feb 7, 2018

Sorry for the quick dirty PR of yesterday.

@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #15 into develop will decrease coverage by 1.12%.
The diff coverage is 26.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #15      +/-   ##
=============================================
- Coverage       83.4%   82.27%   -1.13%     
- Complexity       245      246       +1     
=============================================
  Files             31       32       +1     
  Lines            741      756      +15     
  Branches          28       28              
=============================================
+ Hits             618      622       +4     
- Misses           112      123      +11     
  Partials          11       11
Impacted Files Coverage Δ Complexity Δ
...m/github/ccob/bittrex4j/ConnectionStateChange.java 0% <0%> (ø) 0 <0> (?)
...ava/com/github/ccob/bittrex4j/BittrexExchange.java 76.07% <44.44%> (-1.06%) 53 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e1645...4d96700. Read the comment docs.

@CCob CCob merged commit 3cf9729 into CCob:develop Feb 7, 2018
@CCob
Copy link
Owner

CCob commented Feb 7, 2018

That's better. Thanks. If you submit any more PR's, any chance you can base them on the active develop branch? I try to keep master as the release branch only

@cymp
Copy link
Contributor Author

cymp commented Feb 7, 2018

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants