Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected typo #49

Merged
merged 1 commit into from
Jan 4, 2019
Merged

corrected typo #49

merged 1 commit into from
Jan 4, 2019

Conversation

jasonwee
Copy link
Contributor

@jasonwee jasonwee commented Jan 4, 2019

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage     80.49%   80.49%           
  Complexity      264      264           
=========================================
  Files            35       35           
  Lines           841      841           
  Branches         31       31           
=========================================
  Hits            677      677           
  Misses          148      148           
  Partials         16       16
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/ccob/bittrex4j/BittrexExchange.java 72.43% <100%> (ø) 54 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069e513...98f1b8e. Read the comment docs.

@CCob CCob merged commit db38a8a into CCob:master Jan 4, 2019
@CCob
Copy link
Owner

CCob commented Jan 4, 2019

I must have missed them ones. Although I recommend the websockets method over REST for order book and latest ticker info.

Happy to take a PR if you need them

@CCob
Copy link
Owner

CCob commented Jan 4, 2019

Thanks for the fix

@jasonwee
Copy link
Contributor Author

jasonwee commented Jan 4, 2019

okay clear. was curious why those left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants