implement getorderbook and getticker

[jasonwee]

No description provided.

[codecov]

Codecov Report

Merging #50 into master will increase coverage by 0.5%.
The diff coverage is 93.93%.

@@           Coverage Diff            @@
##             master   #50     +/-   ##
========================================
+ Coverage     80.49%   81%   +0.5%     
- Complexity      264   278     +14     
========================================
  Files            35    38      +3     
  Lines           841   874     +33     
  Branches         31    31             
========================================
+ Hits            677   708     +31     
- Misses          148   149      +1     
- Partials         16    17      +1

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/github/ccob/bittrex4j/dao/OrderBook.java	100% <100%> (ø)	3 <3> (?)
...ain/java/com/github/ccob/bittrex4j/dao/Ticker.java	100% <100%> (ø)	5 <5> (?)
.../com/github/ccob/bittrex4j/dao/OrderBookEntry.java	75% <75%> (ø)	3 <3> (?)
...ava/com/github/ccob/bittrex4j/BittrexExchange.java	73.31% <92.85%> (+0.87%)	57 <3> (+3)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db38a8a...65b80b9. Read the comment docs.

[jasonwee]

hmm.. not sure why codecov failed. Did I miss any tests?

[CCob]

It's because one of the branches on getOrderBook is not tested - "buy/sell" vs "any". How about an enum as the type argument, with "buy", "sell" and "both" as the options? That way it will simplify getOrderBook and the user is forced to pick a valid option. Codecov shouldn't complain then either.

[CCob]

Other than that, looks good to me

[CCob]

Feel free to add yourself as the author too on your new files.

[jasonwee]

okay, now all good. :) could you please make a release because i use this lib?

[CCob]

I will hopefully get some time to kick off a Maven repo build later

[jasonwee]

okay, great.