Building/testing modifies source tree

[alliepiper]

The following files are created in the source tree when building/testing UVCDAT:

installation/install.py
testing/cdms2/junk.xml
testing/dv3d/.baseline_path

I'm not sure what the purpose of the first two are, but the third contains a path to the baseline directory for the dv3d tests. I had added a mechanism to properly pass that path into dv3d via an argument[1], but it appears @ThomasMaxwell reverted my change at some point. This should be cleaned up -- Source clutter with build-dependent info will cause issues when multiple builds reference the same source tree.

[1] 65d545a#diff-d3e8161439180f671ad7a70585da5cc3

[doutriaux1]

install.py is generated by CMake (look for instally.py.in) and can pretty much be moved anywhere, but it probably look for the directory Packages and ocntrib (and maybe install) straight under itself. This whole CDAT install.py file really needs to be taken out completely and we should create a simple [package/contrib]_pkg.cmake etc.. for each pure CDAT packages (or replace dat_pkg). Since everything under there is now pure PYthon (I took libcdms2 out of it if I remember correctly). The junk file is probably useless. Not sure about Tom's bit. @dlonie why don't you re-apply @ThomasMaxwell baseline issue fix you had and we will say that is issue is about taking out install.py all together.

[alliepiper]

We'll look into it, but first I'd like know why @ThomasMaxwell changed it -- I don't want to revert someone else's work without understanding why they made their changes, in case doing so would introduce a problem.

[ThomasMaxwell]

The revert must have been a merge artifact. I’m not aware of any changes of this sort.

— Tom

From: David Lonie <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, June 4, 2015 at 10:41 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Building/testing modifies source tree (#1364)

We'll look into it, but first I'd like know why @ThomasMaxwellhttps://github.com/ThomasMaxwell changed it -- I don't want to revert someone else's work without understanding why they made their changes, in case doing so would introduce a problem.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1364#issuecomment-108919790.

[alliepiper]

Ok, thanks -- I'll see about getting that fixed up.

[alliepiper]

@sankhesh will take a look at the .baseline_path issue.