vcs.Gfb.rename() seems to destroy the object that it's renaming #2116
Comments
@doutriaux1 wasn't sure if you'd seen this yet. |
@embrown I didn't see it but i think I remember you talking to me about it. I'll take a look. |
@doutriaux1 I think I solved this problem. Want me to make a test and submit the new rename() code with a PR? |
sure, but on the vcs repo please. I opened an issue for this there at: CDAT/vcs#2 |
@doutriaux1 should we close this? It was fixed in vcs. |
@embrown please re-open if I have the wrong commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's a session example that I'm running in ipython now:
As we can see from the example, this leaves behind a reference to the renamed boxfill in the names list while making that boxfill unusable, because it is deleted.
I think the issue is that we should just be creating a new boxfill here, instead of using vcs.elements to re-assign things:

Not sure if this is a widespread problem (affecting more than just Gfb).
The text was updated successfully, but these errors were encountered: