121 missing value opacity #123
Conversation
|
@doutriaux1 if this can be added to the |
|
@sankhesh thanks for looking at this, I'm looking forward to getting boxfill working with opacities |
|
@danlipsa Please review |
|
@durack1 Sure thing. |
| pass | ||
| else: | ||
| removeHiddenPoints(grid) | ||
| removeHiddenPointsOrCells(grid, cellData) |
There was a problem hiding this comment.
You are missing the if statement.
| @@ -545,7 +566,7 @@ def genGrid(data1, data2, gm, deep=True, grid=None, geo=None, genVectors=False, | |||
| # hidden point don't work for polys or unstructured grids. | |||
| # We remove the cells in this case. | |||
| if (vg.GetExtentType() == vtk.VTK_PIECES_EXTENT): | |||
| removeHiddenPoints(vg) | |||
| removeHiddenPointsOrCells(vg, False) | |||
There was a problem hiding this comment.
I would change this to:removeHiddenPointsOrCells(vg, cellData=False)
This change makes sure that the hidden cells from the masked dataset are removed before mapping. If they are not removed, they will be visible when the opacity of the mask is less than 100.
sankhesh
force-pushed
the
121_missing_value_opacity
branch
from
1ca3998
to
f6603cd
Compare
|
Thanks @danlipsa. Just pushed the suggested changes. |
|
@sankhesh it would be great to add a test for this, just so future changes (and similar weird behaviours) can be caught by the test suite rather than merged |
|
Good idea @durack1. I'll add it. |
|
@doutriaux1 @durack1 Okay to merge? |
|
@doutriaux1 are we good to go here? I would really like to get these graphics moving |
|
@doutriaux1 just checking https://anaconda.org/uvcdat/vcs-nox/files should a new nightly appear automagically, or can you trigger one? |
Fixes #121