Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

121 missing value opacity #123

Merged
merged 2 commits into from Jan 30, 2017
Merged

Conversation

sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jan 26, 2017

Fixes #121

@durack1
Copy link
Member

durack1 commented Jan 26, 2017

@doutriaux1 if this can be added to the patterns branch and whacked into a nightly I'll give it a run with my failing script

@durack1
Copy link
Member

durack1 commented Jan 26, 2017

@sankhesh thanks for looking at this, I'm looking forward to getting boxfill working with opacities

@sankhesh
Copy link
Contributor Author

sankhesh commented Jan 26, 2017

@danlipsa Please review

@sankhesh
Copy link
Contributor Author

sankhesh commented Jan 26, 2017

@durack1 Sure thing.

@doutriaux1
Copy link
Contributor

doutriaux1 commented Jan 26, 2017

@sankhesh thanks! @danlipsa I will let you double check the removehiddencellpoint section. It looks right to me, but I would feel better if you review it as well. Once you're happy with it please merge in master.

pass
else:
removeHiddenPoints(grid)
removeHiddenPointsOrCells(grid, cellData)
Copy link
Contributor

@danlipsa danlipsa Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the if statement.

@@ -545,7 +566,7 @@ def genGrid(data1, data2, gm, deep=True, grid=None, geo=None, genVectors=False,
# hidden point don't work for polys or unstructured grids.
# We remove the cells in this case.
if (vg.GetExtentType() == vtk.VTK_PIECES_EXTENT):
removeHiddenPoints(vg)
removeHiddenPointsOrCells(vg, False)
Copy link
Contributor

@danlipsa danlipsa Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to:removeHiddenPointsOrCells(vg, cellData=False)

This change makes sure that the hidden cells from the masked dataset are
removed before mapping. If they are not removed, they will be visible
when the opacity of the mask is less than 100.
@sankhesh sankhesh force-pushed the 121_missing_value_opacity branch from 1ca3998 to f6603cd Compare Jan 26, 2017
@sankhesh
Copy link
Contributor Author

sankhesh commented Jan 26, 2017

Thanks @danlipsa.

Just pushed the suggested changes.

@durack1
Copy link
Member

durack1 commented Jan 26, 2017

@sankhesh it would be great to add a test for this, just so future changes (and similar weird behaviours) can be caught by the test suite rather than merged

@sankhesh
Copy link
Contributor Author

sankhesh commented Jan 26, 2017

Good idea @durack1. I'll add it.

@sankhesh
Copy link
Contributor Author

sankhesh commented Jan 27, 2017

@doutriaux1 @durack1 Okay to merge?

@durack1
Copy link
Member

durack1 commented Jan 30, 2017

@doutriaux1 are we good to go here? I would really like to get these graphics moving

@doutriaux1 doutriaux1 merged commit 72b4495 into CDAT:master Jan 30, 2017
@sankhesh sankhesh deleted the 121_missing_value_opacity branch Jan 30, 2017
@durack1
Copy link
Member

durack1 commented Feb 5, 2017

@doutriaux1 just checking https://anaconda.org/uvcdat/vcs-nox/files should a new nightly appear automagically, or can you trigger one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants