Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 1d plot layer based on priority. #199

Closed
wants to merge 1 commit into from
Closed

Conversation

danlipsa
Copy link
Contributor

No description provided.

@@ -103,7 +103,7 @@ def plot(self, data1, data2, tmpl, grid, transform, **kargs):
self._context().canvas.plot(m, donotstoredisplay=True)

ren2 = self._context().createRenderer()
ren2.SetLayer(1)
self._context().setLayer(ren2, tmpl.data.priority)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danlipsa let's hold on on this, I think you want the same priority asthe other renderer which can be 0 if line width is zero. No? I'm pushing a PR with slowdown test in the second. Let's talk again after this ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danlipsa @doutriaux1, why don't we remove the renderer at layer 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashish24 Good question. 😄 I don't fully understand the logic there. I think a good time to revisit this is when we implement the multiplot feature.

@durack1
Copy link
Member

durack1 commented Jun 14, 2017

@danlipsa @doutriaux1 when there is a nightly for this I would be happy to test it with the code in CDAT/cdat#1424, that code seemed to uncover ALOT of these issues pretty well

@danlipsa danlipsa closed this Jun 16, 2017
@danlipsa
Copy link
Contributor Author

This is set in #200

@doutriaux1
Copy link
Contributor

@aashish24 from looking at the clear function, the layer 0 is the background color (i.e white by default) so when we clear we repaint the background.

@doutriaux1 doutriaux1 added this to the 2.12 milestone Sep 6, 2017
@doutriaux1 doutriaux1 deleted the use-1dplot-priority branch October 31, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants