Issue 298 markers default size #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doutriaux1 @aashish24 Take a look my commit. Seems that the special scaling was caused by code in vcs. I uploaded new baselines that look right. |
|
@danlipsa it was here on purpose, otherwise for size one they're ridiculously small. try different size like 20 next, you'll see it does not seem to scale properly. |
danlipsa
reviewed
Jan 22, 2018
| @@ -11,7 +11,7 @@ def testMintics(self): | |||
| line.linecolor = "red" # Red color obviously | |||
| line.linewidth = 2. # A bit thicker | |||
| line.marker = "circle" # | |||
| line.markersize = 10 # A bit bigger | |||
| line.markersize = 1 | |||
| s = MV2.array(s) | |||
There was a problem hiding this comment.
Is markersize 1 the default?
| @@ -20,7 +20,7 @@ def testVCSWMO(self): | |||
| m.worldcoordinate = [0, M, 0, M] | |||
| m.type = wmo | |||
| m.color = [242, ] | |||
| m.size = [10., ] | |||
| m.size = [20., ] | |||
| xs = [] | |||
There was a problem hiding this comment.
Why isn't this one set to 1 as well and change everything else proportionally?
|
|
|
@danlipsa I don't know why it wasn't working for me! w/o *=10 it was the tiniest markers ever... If you're happy with the PR as is please merge in |
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danlipsa @aashish24 please review. Blines at: CDAT/uvcdat-testdata#184
Thre goal of this PR is to make all markers have similar size for a given value of the marker size, no matter what the marker type is (at the present the hurrican was way bigger)
NOTE: there is an issue with cross and plus markers they do not scale properly. I got them t be all roughly of the same size for a marker size of 1. But when changing to size 5 or 10 all markers scale similarly exceot for plus and cross. The SetScale option on the vtkGlyphSource2D object seems to behave differently for the "Cross" glyph type. At @aashish24 I played with SetScale2 but to no luck so far.
Most striking example can be seen at:
https://github.com/UV-CDAT/uvcdat-testdata/pull/184/files#diff-e2de5072ad476a7a887c81f48602561b
or
https://github.com/UV-CDAT/uvcdat-testdata/pull/184/files#diff-4bc0717af7c272ffff5c6fbc4eacaa35