-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aspect ratio of logo image so it is not stretched or squashed #376
Conversation
@doutriaux1 Any idea why every test is failing with the following stack trace?
|
@dnadeau4 it propagated everywhere. It is now an emergency to figure out why cdtime suddenly fails. |
@dnadeau4 actually it looks like it needs |
I removed yesterday Linux builds. Fingers crossed. |
@scottwittenburg it's passing now that I removed the faulty cdtime. @dnadeau4 we still need to investigate that cdtime issue though... 😢 |
@scottwittenburg we should add a test for this. |
Agreed @doutriaux1 I'll add a test. |
0d0533a
to
97bdd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove .last_failure and tests/test_vcs_png_window_resize2_.png files
Thx for adding a test
Also add two new tests that make sure logo stays the right aspect ratio whether the canvas is tall/narrow or short/wide.
97bdd3b
to
2ad0f73
Compare
Gah! Sorry about that @doutriaux1, it's too easy to just say |
No description provided.