Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile #446

Merged
merged 37 commits into from Jul 4, 2020
Merged

Add makefile #446

merged 37 commits into from Jul 4, 2020

Conversation

jasonb5
Copy link
Contributor

@jasonb5 jasonb5 commented Jun 3, 2020

  • Updates makefile to continue using CDAT/conda-recipes for rerender/building similar to conda-forge process.
  • Updates circleci config to use makefile.
  • Stores package and spec list during build process, assist in reproduce failed environments.

muryanto1 and others added 30 commits Jun 1, 2020
Copy link
Member

@muryanto1 muryanto1 left a comment

we will need to revisit running tests with coverage.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
cd uvcdat-testdata; git pull
endif

run-tests:
Copy link
Member

@muryanto1 muryanto1 Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible for 'make run-tests' to return the value returned my "python run_tests.py..."? In circleci, when I run the workflow, if any test failed, I want to exit the circleci workflow.
In nightly test runs though (another circleci workflow), I ran test suites of all projects, if any test suite fail, I want to keep on running the project's test suite. I.e. in this case I will just ignore the exit value of 'make run-tests'.

@muryanto1 muryanto1 marked this pull request as ready for review Jul 4, 2020
@muryanto1 muryanto1 merged commit b0e917b into master Jul 4, 2020
14 checks passed
@muryanto1 muryanto1 deleted the add_makefile branch Jul 4, 2020
@downiec downiec modified the milestones: 8.2, 8.2.1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants