Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Feature/dev 4215 brush barchart pt3 #805

Closed
wants to merge 14 commits into from

Conversation

tturnerswdev33
Copy link
Contributor

@tturnerswdev33 tturnerswdev33 commented Aug 31, 2023

Briefly describe your changes

Went back to separating regular chart from brush chart bc brush is NOT passing domain onBrushChange...

FINAL STATE on last day working on this:
The final push broke the brush from working on AREA CHART because I was recklessly just trying to get bar chart working. You will need to look at 2nd or 3rd commit from the end to see how area chart works OR once bar chart works use same techniques for area chart.

Bar Chart

  • brush displays
  • can drag brush and it sets the left and right x values in state
  • it calls onBrushChange and gets those x values
  • but then you need to add code to use those x values in comparison to the x axis to then FILTER the data
  • once you do that and set the filtered date in the state, then the top bar chart should then update on that state change

*** DID NOT REMOVE CONSOLE.LOGS so you can re-use them if need be in debugging this
DID NOT resolve conflicts either

Checklist before requesting a review

  • My pull request was branched from and targets the test branch
  • I have performed a self-review of my code
  • I have manually tested all packages affected (bonus points for automations)
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have checked to ensure there aren't other open pull requests for the same change

Did you test your feature in the following environments?

  • Standalone Component
  • Standalone Full Editor
  • CDC Internal Checks

@adamdoe adamdoe added the Hold label Sep 8, 2023
@adamdoe adamdoe closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants