-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-6596] data driven grouped tables #985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't catch that this was just a draft. I think its looking good so far. I didn't dive into the table stuff deep, I'll trust that that's looking good since you're in the weeds with it. The two things that did come up for me were 1) deletions from EditorPanel. I'm wondering if they showed as unused but are actually needed. It seemed like a good chunk was stripped out and I'm pretty sure the DataSuppression component and remove series functions needs to stay in. So maybe double check deletions there. 2) The DataImport file was changed to use .json. Does that break csv imports?
|
2ee57d7
to
06f6bb6
Compare
@adamdoe some of the work to pull out the helper functions from CdcChart aren't needed for this PR. I started doing it because I needed to figure out something else, I think it simplifies CdcChart a lot though so I left it in. Let me know if you want me to put that change in a different PR. Also I'm waiting for an okay from my DBA about the data structure for the table, once I get that I'll move this out of draft. |
516d045
to
d3144a1
Compare
… when row_type is active
added pie chart example and added grouped table example to storybook