Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for Batch using mock objects #123

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Unit tests for Batch using mock objects #123

merged 8 commits into from
Sep 17, 2024

Conversation

xop5
Copy link
Contributor

@xop5 xop5 commented Sep 4, 2024

Use unittest mock objects to test the batch pool creation

@xop5 xop5 mentioned this pull request Sep 9, 2024
1 task
@natemcintosh
Copy link

This looks great! So happy to finally have some tests for this library. That said, it looks like we still need to set up CI for the tests.

I'd recommend something like this since both projects use poetry. That said, it'll need a little work to remove the PyRenew specific parts.

@xop5 xop5 merged commit db00398 into master Sep 17, 2024
@xop5 xop5 deleted the mock_tests branch September 17, 2024 10:41
@xop5
Copy link
Contributor Author

xop5 commented Sep 17, 2024

#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants