Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHDC XML validation to integration tests #1423

Merged
merged 54 commits into from
Mar 8, 2024

Conversation

robertmitchellv
Copy link
Collaborator

PULL REQUEST

Summary

Adding PHDC XML validation to integration tests. This will take a prepared FHIR bundle and run it through the PHDC Case Report parser to the PHDC Builder to produce PHDC Case Report XML that is checked against the HL7 CDA schema, which includes the SDTC extensions.

Additionally we're also adding the ability to set the correct xsi:type for <value> child elements of <observation>, which affects validation.

Related Issue

Fixes:

Additional Information

XML validation is pain 🤕

m-goggins and others added 30 commits February 23, 2024 12:20
@robertmitchellv robertmitchellv self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (dd3b5ec) to head (0ae1f25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          48       48           
  Lines        3048     3048           
=======================================
  Hits         2955     2955           
  Misses         93       93           
Flag Coverage Δ
unit-tests 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@robertmitchellv robertmitchellv marked this pull request as ready for review March 6, 2024 23:41
@robertmitchellv
Copy link
Collaborator Author

@DanielPaseltiner i think i'm going to address the new FHIR bundle after this lands if that sounds ok? unless you have strong feelings then i can add it to this work

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for slogging through on this one.

@robertmitchellv
Copy link
Collaborator Author

@DanPaseltiner @m-goggins i added some changes after Dan approved because i was in the middle of moving some things around to make it easier to read assets from the different places in the tests so want to make sure you both have a chance to weigh in before i merge

@robertmitchellv robertmitchellv added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 3afb01f Mar 8, 2024
40 checks passed
@robertmitchellv robertmitchellv deleted the robert/1069-phdc-validation-integration branch March 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants