-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHDC XML validation to integration tests #1423
Add PHDC XML validation to integration tests #1423
Conversation
… into clean-up-phdc-test-data
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 48 48
Lines 3048 3048
=======================================
Hits 2955 2955
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. |
@DanielPaseltiner i think i'm going to address the new FHIR bundle after this lands if that sounds ok? unless you have strong feelings then i can add it to this work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for slogging through on this one.
…are functions and added fixtures where needed
@DanPaseltiner @m-goggins i added some changes after Dan approved because i was in the middle of moving some things around to make it easier to read assets from the different places in the tests so want to make sure you both have a chance to weigh in before i merge |
PULL REQUEST
Summary
Adding PHDC XML validation to integration tests. This will take a prepared FHIR bundle and run it through the PHDC Case Report parser to the PHDC Builder to produce PHDC Case Report XML that is checked against the HL7 CDA schema, which includes the SDTC extensions.
Additionally we're also adding the ability to set the correct
xsi:type
for<value>
child elements of<observation>
, which affects validation.Related Issue
Fixes:
/fhir-to-phdc
is finished, run the returned PHDC XML output through an integration test via GitHub Actions #1069xsi:type
to<value>
child element of<observation>
in PHDC #1406Additional Information
XML validation is pain 🤕