Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestration sends data to ecr viewer instead of directly to s3 or postgres #1464

Merged
merged 12 commits into from
Mar 13, 2024

Conversation

KennethSkylight
Copy link
Collaborator

PULL REQUEST

Summary

ECR Viewer has the endpoint to save fhir bundle data to s3 or postgres. Orchestration is now changed so it sends the bundle data to ecr viewer.

All boto3 and s3 references are taken out as well as direct postgres inserts

Related Issue

Fixes #1332

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (d749658) to head (822b1e2).

❗ Current head 822b1e2 differs from pull request most recent head 238fb63. Consider uploading reports for the commit 238fb63 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          48       48           
  Lines        3048     3048           
=======================================
  Hits         2955     2955           
  Misses         93       93           
Flag Coverage Δ
unit-tests 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . Looks good, but looks like some tests are still failing.

@KennethSkylight KennethSkylight added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 990d4cc Mar 13, 2024
40 checks passed
@KennethSkylight KennethSkylight deleted the orchestration-to-s3 branch March 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update orchestration service to save data via eCR Viewer
3 participants