-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchestration sends data to ecr viewer instead of directly to s3 or postgres #1464
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 48 48
Lines 3048 3048
=======================================
Hits 2955 2955
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 . Looks good, but looks like some tests are still failing.
PULL REQUEST
Summary
ECR Viewer has the endpoint to save fhir bundle data to s3 or postgres. Orchestration is now changed so it sends the bundle data to ecr viewer.
All boto3 and s3 references are taken out as well as direct postgres inserts
Related Issue
Fixes #1332