Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate github workflows by container #1965

Merged
merged 92 commits into from
Jun 18, 2024
Merged

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Jun 12, 2024

PULL REQUEST

Summary

Breaks out the test.yaml file for separate test workflows for each container. The tests are triggered when there are changes to the container and its dependencies (except orchestration, which is run whenever there are any changes). See table for

image

Related Issue

Fixes #1951

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@m-goggins m-goggins changed the title add separate workflow for dibbs container Separate github workflows by container Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (445e545) to head (9f0e241).
Report is 4 commits behind head on main.

Current head 9f0e241 differs from pull request most recent head fd46360

Please upload reports for the commit fd46360 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          48       48           
  Lines        3053     3053           
=======================================
  Hits         2962     2962           
  Misses         91       91           
Flag Coverage Δ
unit-tests 97.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@robertandremitchell
Copy link
Collaborator

Broadly LGTM as well. Rob, if I had to guess, the services where we use build-args are those where we're accessing something from a licensed secret (i.e. we only use them for SMARTY creds or URLs for other services we've deployed). I think this is a little bit unsatisfying as an answer because in something like the Orchestration service, we have database login information set as an environment variable, and that info clearly has just as much of a right to be protected as a SMARTY cred. I think what this might just come down to is that we used SMARTY and referential URLs back when we had all this deployed in Azure with LAC, and so secrets + Keyvault management was something we just sort of got accustomed to setting up. So I think it might honestly just be an evolution of our product that we switched from build args and secrets to environment variables. I'm okay to give this an approval, but will wait until we get any more discussion or input on the build args point.

ah, yeah, that makes sense. I thought they were there for orchestration's sake, which would have meant needing them for all services.

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for putting this together. I think this will be a huge improvement. Couple comments below that I'm happy to discuss further, but nothing that is blocking.

.github/codecov.yml Show resolved Hide resolved
@m-goggins m-goggins added this pull request to the merge queue Jun 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2024
@m-goggins m-goggins added this pull request to the merge queue Jun 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2024
@m-goggins m-goggins added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 5f426f2 Jun 18, 2024
34 checks passed
@m-goggins m-goggins deleted the 1951-separate-github-workflows branch June 18, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPIKE: investigate and communicate about making separate github workflows per container to simplify testing
6 participants