-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate github workflows by container #1965
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 48 48
Lines 3053 3053
=======================================
Hits 2962 2962
Misses 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. |
ah, yeah, that makes sense. I thought they were there for orchestration's sake, which would have meant needing them for all services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for putting this together. I think this will be a huge improvement. Couple comments below that I'm happy to discuss further, but nothing that is blocking.
…DCgov/phdi into 1951-separate-github-workflows
…DCgov/phdi into 1951-separate-github-workflows
…DCgov/phdi into 1951-separate-github-workflows
…DCgov/phdi into 1951-separate-github-workflows
PULL REQUEST
Summary
Breaks out the
test.yaml
file for separate test workflows for each container. The tests are triggered when there are changes to the container and its dependencies (except orchestration, which is run whenever there are any changes). See table forRelated Issue
Fixes #1951
Additional Information
Anything else the review team should know?
Checklist