Handle multiple phone number formats in search #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPaseltiner
requested changes
Jul 25, 2024
Comment on lines
37
to
45
| export function FormatPhoneAsDigits(givenPhone: string) { | ||
| // Start by getting rid of all existing separators for a clean slate | ||
| const newPhone: string = givenPhone.replace(/\D/g, ""); | ||
| if (newPhone.length != 10) { | ||
| return givenPhone; | ||
| } | ||
| return newPhone; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should move this functionality into the query service or utils so that it is available for use on the API side of things as well.
There was a problem hiding this comment.
Oh duh, I was so focused on the different formats I forgot the API side. I'll get it sorted.
There was a problem hiding this comment.
No worries! I was starring at this for a while before I realized what was bugging me about it. We are building two interfaces that expose the same functionality so we just need to keep that in mind with structuring the code.
robertandremitchell
approved these changes
Jul 30, 2024
DanPaseltiner
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This PR handles the MVP of phone number formatting for our query search; the phone number passed in the search field gets stripped to just be digits, and then based on some profiling of the most common formatting schemes present in HAPI, Epic, and Cerner, we spit back out an array of possible formattings with some combinations of spaces, dashes, and parentheticals. These all get logically
OR'ed in the query URL search proper.Related Issue
Fixes #1840
Additional Information
The idea for this approach came out of some conversations with Dan, but the idea is to basically take a much wider shotgun-style approach to hitting phone numbers, since the big FHIR servers all enforce exact only matching on the telecom field (that means we need to perfectly hit how they distribute all their delimiters, parentheses, etc.). We're making the choice right now to kind of ignore country code parsing--eventually, we'll want to have a separate country code field that starts off with a default value of 1 (for US numbers) because then we can more explicitly handle country digits. If we tried to handle it now, we run into some very hairy and not-worth-it-to-sort-out cases. For example, there's no way to tell if a number with 10 digits includes a country code and omits local-area routing, or if it's some other partial phone number, etc. So we're just gonna ignore it for this PR. Later on though, we can also use the country code text input field for switch-statement logic to check different formatting options more common to international numbers. That code will just have to come after we have a country code box.