Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient Banner #2241

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Patient Banner #2241

merged 10 commits into from
Jul 30, 2024

Conversation

JNygaard-Skylight
Copy link
Collaborator

PULL REQUEST

Summary

A sticky banner displaying the patient's name and date of birth is now shown. If the environmental variable STANDALONE_VIEWER is truthy, the banner will not be shown. Otherwise, it will be visible.

Related Issue

Fixes #2185

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@JNygaard-Skylight
Copy link
Collaborator Author

@sarahtress this is ready for design review:
image
image

@sarahtress
Copy link
Collaborator

@JNygaard-Skylight would it be out of scope for this ticket to change the header to align with the patient banner? like this:
352233407-edfaa557-080c-4d0a-b004-ba454c8792f4

@JNygaard-Skylight
Copy link
Collaborator Author

@JNygaard-Skylight would it be out of scope for this ticket to change the header to align with the patient banner? like this: 352233407-edfaa557-080c-4d0a-b004-ba454c8792f4

I can do that with this PR.

@JNygaard-Skylight
Copy link
Collaborator Author

@sarahtress Does this look better?
image
image

@sarahtress
Copy link
Collaborator

@JNygaard-Skylight yes! except, the font sizes look off between the patient banner and the header. patient banner should be 1.375rem while the font size for the header should be 2 rem. could you also adjust that? and then should be all good to go!

@JNygaard-Skylight
Copy link
Collaborator Author

@sarahtress how is this?
image
image

@sarahtress
Copy link
Collaborator

@JNygaard-Skylight looks great! thank you!

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Could we also use rem instead of px on whatever is new?

containers/ecr-viewer/src/styles/custom-styles.scss Outdated Show resolved Hide resolved
containers/ecr-viewer/src/styles/custom-styles.scss Outdated Show resolved Hide resolved
containers/ecr-viewer/src/styles/custom-styles.scss Outdated Show resolved Hide resolved
containers/ecr-viewer/src/styles/custom-styles.scss Outdated Show resolved Hide resolved
containers/ecr-viewer/src/app/Header.tsx Outdated Show resolved Hide resolved
@JNygaard-Skylight
Copy link
Collaborator Author

@sarahtress I made @BobanL's fixes, does it still look good:
image

@sarahtress
Copy link
Collaborator

looks good to me!

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@JNygaard-Skylight JNygaard-Skylight added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 30, 2024
Merged via the queue into main with commit 174c345 Jul 30, 2024
12 checks passed
@JNygaard-Skylight JNygaard-Skylight deleted the josh/patient-banner branch July 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Banner | eCR Viewer
4 participants