-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patient Banner #2241
Patient Banner #2241
Conversation
@sarahtress this is ready for design review: |
@JNygaard-Skylight would it be out of scope for this ticket to change the header to align with the patient banner? like this: |
I can do that with this PR. |
@sarahtress Does this look better? |
@JNygaard-Skylight yes! except, the font sizes look off between the patient banner and the header. patient banner should be 1.375rem while the font size for the header should be 2 rem. could you also adjust that? and then should be all good to go! |
@sarahtress how is this? |
…Cgov/phdi into josh/patient-banner
@JNygaard-Skylight looks great! thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. Could we also use rem
instead of px
on whatever is new?
@sarahtress I made @BobanL's fixes, does it still look good: |
looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎆
PULL REQUEST
Summary
A sticky banner displaying the patient's name and date of birth is now shown. If the environmental variable
STANDALONE_VIEWER
is truthy, the banner will not be shown. Otherwise, it will be visible.Related Issue
Fixes #2185
Additional Information
Anything else the review team should know?
Checklist