Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecr table pagination frontend #2376

Merged
merged 24 commits into from
Aug 14, 2024
Merged

ecr table pagination frontend #2376

merged 24 commits into from
Aug 14, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Aug 13, 2024

PULL REQUEST

Summary

  • Add count of items in bottom right of pagination bar
  • Add select to change number of items per page
    • First, items per page is stored in local storage once changed in the select menu.
    • Then, the url search params are updated to be accessible by server components.
  • Copy Trussworks USWDS Pagination to add additional enhancements

Related Issue

Fixes #2190

Additional Information

  • Select menu does not match figma designs exactly as I was unable to customize the select menu using the USWDS component.
  • Left in an additional option of 6 per page to view with the limited amount of data we have
  • Cookies are only available for server components

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@BobanL BobanL marked this pull request as ready for review August 13, 2024 19:50
@BobanL BobanL requested a review from sarahtress August 13, 2024 19:50
@sarahtress
Copy link
Collaborator

@BobanL looks good to me, as long as we have a ticket in the future to remove the option for 6 eCRs on a page in the future!

@BobanL BobanL removed the request for review from sarahtress August 13, 2024 21:40
@BobanL BobanL force-pushed the boban/2190-frontend-pagination branch from 405f93b to 382f0dc Compare August 14, 2024 18:13
@BobanL BobanL requested a review from lina-roth August 14, 2024 18:14
Copy link
Collaborator

@lina-roth lina-roth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Approved!

@BobanL BobanL added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 6e50c21 Aug 14, 2024
20 checks passed
@BobanL BobanL deleted the boban/2190-frontend-pagination branch August 14, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRONTEND eCR Library Pagination Upgrade | Non-Integrated eCR Viewer
3 participants