Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecrs, update seed script for subfolders #2528

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add ecrs, update seed script for subfolders #2528

merged 1 commit into from
Sep 10, 2024

Conversation

lina-roth
Copy link
Collaborator

@lina-roth lina-roth commented Sep 10, 2024

PULL REQUEST

Summary

What changes are being proposed?

  • Add ECRs from LA and TN (Added from QA tickets and rest from LAC data)
  • Update seed script to check subfolders (LA, TN, ME)
  • Updated data.sql

Related Issue

Fixes #2323

Acceptance Criteria

Increase amount of seeded eCRs to about 100

Additional Information

Anything else the review team should know?

  • Seed script takes 5-10 mins to run

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested and it works for me.

@lina-roth lina-roth added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 4ce44ae Sep 10, 2024
11 checks passed
@lina-roth lina-roth deleted the lr/add-100 branch September 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load more eCRs into eCR homepage to make eCR Library feel more realistic
2 participants