Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated message parser to handle nulls and then provided sample file #830

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

BradySkylight
Copy link
Contributor

PULL REQUEST

Summary

The message parser was returning "" instead of null as the value of an element if it wasn't in the FHIR Bundle. This caused issues downstream, especially with numeric fields. This PR includes the changes to send back null when necessary as well as a sample response from the message parser with these changes included.

Related Issue

None

Additional Information

This change was made in conjunction to @m-goggins work on the ECR Data Store.

@BradySkylight BradySkylight added ecr Any work revolving around parsing, converting, mapping, transforming, seeding for ecr messages viper labels Sep 15, 2023
@BradySkylight BradySkylight self-assigned this Sep 15, 2023
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BradySkylight BradySkylight merged commit d585c7a into main Sep 15, 2023
25 checks passed
@BradySkylight BradySkylight deleted the brady/message-parser-handle-nulls branch September 15, 2023 17:27
@nickclyde nickclyde mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecr Any work revolving around parsing, converting, mapping, transforming, seeding for ecr messages viper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants