Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Check for RR field presence before merging RR to eCR" #868

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

emmastephenson
Copy link
Collaborator

Reverts #866

The integration tests for the containers are failing - can't replicate locally yet, but going to roll back this change until I figure out what's going on.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #868 (8d10b68) into main (397f6e8) will decrease coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
- Coverage   96.40%   96.37%   -0.04%     
==========================================
  Files          46       46              
  Lines        2645     2645              
==========================================
- Hits         2550     2549       -1     
- Misses         95       96       +1     
Flag Coverage Δ
unit-tests 96.37% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emmastephenson
Copy link
Collaborator Author

Integration tests are failing because they point at the main version of the SDK, which is broken...hence the rollback 🤦 But those aren't required, so merging regardless!

@emmastephenson emmastephenson merged commit 2220437 into main Oct 17, 2023
17 of 20 checks passed
@emmastephenson emmastephenson deleted the revert-866-emma/844-rr-check branch October 17, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants