Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache external source ids #919

Merged
merged 32 commits into from
Nov 13, 2023
Merged

Cache external source ids #919

merged 32 commits into from
Nov 13, 2023

Conversation

DanPaseltiner
Copy link
Collaborator

PULL REQUEST

Summary

This PR introduces caching for our queries to retrieve external_source_id. This will help to further decrease the load that the record linkage service in placing on the MPI database.

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #919 (f2457f8) into main (7a6d9ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f2457f8 differs from pull request most recent head 68170e8. Consider uploading reports for the commit 68170e8 to get more accurate results

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   96.71%   96.72%           
=======================================
  Files          48       48           
  Lines        2804     2811    +7     
=======================================
+ Hits         2712     2719    +7     
  Misses         92       92           
Flag Coverage Δ
unit-tests 96.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
phdi/linkage/mpi.py 97.76% <100.00%> (+0.09%) ⬆️

Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

phdi/linkage/mpi.py Show resolved Hide resolved
@DanPaseltiner DanPaseltiner merged commit 50f71b6 into main Nov 13, 2023
18 checks passed
@DanPaseltiner DanPaseltiner deleted the cache-external-source-ids branch November 13, 2023 19:11
@nickclyde nickclyde mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants