Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change datetime import to be compatible with other imports #925

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

m-goggins
Copy link
Collaborator

PULL REQUEST

Summary

Change the import of datetime to be compatible with Synapse datetime import

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #925 (28704fc) into main (b75c258) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          48       48           
  Lines        2811     2811           
=======================================
  Hits         2719     2719           
  Misses         92       92           
Flag Coverage Δ
unit-tests 96.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
phdi/linkage/seed.py 100.00% <100.00%> (ø)

@nickclyde nickclyde mentioned this pull request Nov 13, 2023
@m-goggins m-goggins merged commit 57ad212 into main Nov 13, 2023
20 checks passed
@m-goggins m-goggins deleted the fix-datetime-datetime branch November 13, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants