Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stale Websocket Code #83

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

mwodahl
Copy link

@mwodahl mwodahl commented May 29, 2024

PR Details

Description

This update removes stale 'deposit over WebSocket to SDX' code from the ODE. The documentation for this feature was removed in this PR: #73.

Motivation and Context

This functionality is no longer supported, however, the code for this functionality still exists in the ODE. By removing this stale code the ODE now reflects the updated documentation.

How Has This Been Tested?

This has been tested locally using docker-compose. The TIM deposit, log offload, and file upload data paths were all verified to work correctly with these changes.

Types of changes

  • [ X ] Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X ] I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • [ X ] All new and existing tests passed.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for doing this! Unit tests pass & the code changes look good!

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Unit tests all pass, and looking good

@payneBrandon payneBrandon merged commit 5c102cd into dev Jul 8, 2024
4 checks passed
@payneBrandon payneBrandon deleted the Update/remove-websocket-code branch July 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants