Fix searching and faceting on multiline values #82
Conversation
Values indexed which have newline characters weren't matched if passed as parameters, such as when stored in hidden inputs once being faceted They would only work when searched via preconstructed URI-encoded URLs
|
I'm tempted to say that we ought to change the data repository to automatically normalize all the spaces in fields going to text fields, and probably the keywords, too. I agree that this could potentially break other queries for searches... Hmm. What do you think? |
|
See comment on the related issue: #81 (comment) The normalize space method is different than removing vertical space though, right? We're can't globally remove vertical space. |
|
@techgique the original normalize-space from XSLT does remove vertical space, so it depends, I guess, if we want to imitate that entirely. |
|
Looking at these changes, I think I feel kinda confused. Like, if the elasticsearch index has a field with a return line in it, then how would the searches here which remove the return line actually match against it? Would you be up for writing a couple tests? I don't think we have any integration tests, unfortunately, but I would feel a little better about having the expected behavior lined out in them with these changes. |
|
They match after this change because the indexed values in Elasticsearch only have LF characters for new lines. But when Orchid renders the values in hidden I can work on adding comments and tests for this if you want to handle the data repo changes for keyword fields? |
Remove the
%0Din the API requests for facets and filters.Fixes #81
However, I'm concerned that this may potentially break other queries if we want to allow searches trying to match values with CRs, perhaps via
<textarea>inputs for API search. We aren't using any currently that I'm aware of. None of the current facet URLs in Cather Letters have%0Din them, so this approach seems safe at the moment.@jduss4 is more familiar with this repository and may have other ideas how to implement this, perhaps making its behavior with Orchid less complicated. I realize now that I didn't add comments, so we'll want to add some information in the code too.