Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitman fixes #226

Merged
merged 10 commits into from
Aug 28, 2024
Merged

Whitman fixes #226

merged 10 commits into from
Aug 28, 2024

Conversation

wkdewey
Copy link
Contributor

@wkdewey wkdewey commented Apr 15, 2024

No description provided.

@wkdewey wkdewey changed the base branch from dev to new_fields April 15, 2024 21:28
This was linked to issues Aug 8, 2024
Nil checking, XML methods, and API v1 #229
Open
hardcoded EAD collection name #225
Open
Add a cut off for size of text to add to ES #224
Open
techgique
techgique requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@techgique techgique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this smaller PR commit by commit and found a couple things I had questions on. Please take a look.

lib/datura/to_es/vra_to_es/fields.rb Show resolved Hide resolved
lib/datura/to_es/ead_to_es_items/fields.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@wkdewey wkdewey requested a review from techgique August 28, 2024 14:54
@techgique
Copy link
Member

Thanks for the fixes!

@techgique techgique merged commit 67eedaa into new_fields Aug 28, 2024
@techgique techgique deleted the whitman-fixes branch August 28, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techgique techgique techgique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wkdewey @techgique