Add section class to <html>; Clear up helper use #31
Conversation
Add class="site_(section)" to <html> element Application helper site_section called from application layout view Uses the first value from: - Manual override in @site_section instance variable - "home" if a request for the home page - A sub-uri or namespace name in the path - Path name if it matches the controller or action name - "pages" as the last default Change generator to copy extendable helper files to main app Remove Orchid::ApplicationHelper include from Orchid::ItemsHelper as included app-wide by application_helper.rb copied to main app
| # Use override from instance variable | ||
| section = @site_section | ||
| else | ||
| if current_page?(home_path) |
There was a problem hiding this comment.
since this is a rails method, would it fit the style guide better without parentheses? I prefer to read it this way, honestly, but I wanted to see if I have the wrong idea in mind for the style guide's preferences.
There was a problem hiding this comment.
You're right. I think I wrote it that way because I looked at the API and all their examples are written with parentheses. http://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-current_page-3F
I'll fix it :)
There was a problem hiding this comment.
If you decide you would be okay with switching everything ever to parentheses, let me know, and I will start search and replacing immediately with gusto!
| @@ -121,6 +122,13 @@ def gitignore | |||
| return "Orchid .gitignore file copied to app's root directory" | |||
| end | |||
|
|
|||
| def helpers | |||
| FileUtils.rm("#{@new_app}/app/helpers/application_helper.rb") | |||
| FileUtils.cp(Dir.glob("#{@this_app}/app/helpers/*_helper.rb"), "#{@new_app}/app/helpers/") | |||
There was a problem hiding this comment.
I suppose I could test this out, but this is only copying the reference helpers, and not searching recursively the copy the actual filled out helpers, right?
There was a problem hiding this comment.
Correct. As intended. If we copy the actual helpers, then Orchid updates would need to be copied into the main app.
This uses the fancier path searching where it knows to look in engines' helper directories for the include files. Similar to how the include directive in the main app's application.js will look in the asset directories of engines, gems, vendor/, etc and can grab orchid.js from the Gem without copying the file into the main app.
There was a problem hiding this comment.
Right, that's why I wanted to double check that it was only grabbing the referencing helpers. Cool deal. :)
Add class="site_(section)" to element
Application helper site_section called from application layout view
Uses the first value from:
Change generator to copy extendable helper files to main app
Remove Orchid::ApplicationHelper include from Orchid::ItemsHelper as
included app-wide by application_helper.rb copied to main app
Close #15