Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarting fista #35

Merged
merged 13 commits into from
Mar 15, 2019
Merged

Restarting fista #35

merged 13 commits into from
Mar 15, 2019

Conversation

zaccharieramzi
Copy link
Collaborator

This solves #34 .

@coveralls
Copy link

coveralls commented Mar 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 128

  • 54 of 59 (91.53%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.456%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modopt/opt/algorithms.py 48 53 90.57%
Totals Coverage Status
Change from base Build 124: -0.2%
Covered Lines: 1606
Relevant Lines: 1665
💛 - Coveralls

sfarrens
sfarrens approved these changes Mar 15, 2019
View reviewed changes
modopt/tests/test_opt.py Show resolved Hide resolved
@sfarrens
Copy link
Contributor

@zaccharieramzi I think you should add yourself as an author of algorithms.py as with this PR you have contributed a lot to this module.

@zaccharieramzi
Copy link
Collaborator Author

Done (dk if I did the right way though). I put my CEA address and not the permanent one.

sfarrens
sfarrens reviewed Mar 15, 2019
View reviewed changes
modopt/opt/algorithms.py Outdated
@@ -5,6 +5,7 @@
This module contains class implementations of various optimisation algoritms.

:Author: Samuel Farrens <samuel.farrens@cea.fr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best if you do the following:

:Author: Samuel Farrens <samuel.farrens@cea.fr>, Zaccharie Ramzi <zaccharie.ramzi@cea.fr>

@sfarrens sfarrens merged commit 18400b8 into CEA-COSMIC:master Mar 15, 2019
@sfarrens sfarrens mentioned this pull request Mar 15, 2019
Closed
@zaccharieramzi zaccharieramzi mentioned this pull request Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfarrens sfarrens sfarrens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaccharieramzi @coveralls @sfarrens