Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing for a release v0.3 #120

Merged
merged 11 commits into from
Apr 22, 2021
Merged

Preparing for a release v0.3 #120

merged 11 commits into from
Apr 22, 2021

Conversation

chaithyagr
Copy link
Contributor

@chaithyagr chaithyagr commented Apr 20, 2021 •
edited
Loading

This PR holds the release for v0.3.
We will have pyNFFT as an optional install clearing the way for easier install for users. The README is appropriately updated.
Also, I have added the current maintainers/developers in the README.

The updates in this release include:

  1. Remove examples and remove unwanted imports #118 Refactor and remove unwanted imports in CircleCI
  2. [SHORT] Fix up codes for FFT class, making it more user friendly and fix grid search #111 Fix FFT class, move to scipy.fft to better handle multi-process. Also fix the grid-search
  3. Fix normalize_frequency_locations #113 Fix the normalize_frequency_locations code to work well with given KMax
  4. Add oscar scale based proximity #114 Add oscar regularization based on scale

@chaithyagr
Copy link
Contributor Author

@sfarrens let me know if you have issues in running things on Mac. I will try to see if I can get a CI up for mac (currently I didnt considering that our tests are extensive and take a lot of time)

sfarrens
sfarrens reviewed Apr 21, 2021
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@sfarrens
Copy link
Contributor

Hi @chaithyagr this branch builds fine on my mac so I think everything should be fine to release.

I made one comment regarding the installation of pyNFFT on macOS. If pyNFFT will work then I suggest you make the proposed change. If not, then I would recommend we simply remove the macOS section until we have a stable solution. Hopefully by the next release.

zaccharieramzi
zaccharieramzi approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaithyagr
Copy link
Contributor Author

Currently, the tests are failing due to issues in Modopt. @sfarrens can you please make a release of Modopt so that I can make a release here?

@sfarrens
Copy link
Contributor

@chaithyagr I am waiting for a review of the ModOpt release PR then I will release a new patch.

@sfarrens
Copy link
Contributor

@chaithyagr ModOpt v1.5.1 has been released.

@chaithyagr chaithyagr merged commit cf43910 into CEA-COSMIC:master Apr 22, 2021
paquiteau pushed a commit to paquiteau/pysap-mri that referenced this pull request May 21, 2021
@chaithyagr @paquiteau
Preparing for a release v0.3 (CEA-COSMIC#120)
69e5f73 
* Version Bump

* Make pynfft as optional install

* Update the circleci testbench

* Fix Readme

* Update the readme

* Release v0.3 change

* Loosen the install for scikit-image

* Update readme to conda

* Slacken the test_scripts

* Circleci pull latest modopt

* Circleci pull latest modopt

Co-authored-by: chaithyagr <chaithyagr@gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfarrens sfarrens sfarrens approved these changes

@zaccharieramzi zaccharieramzi zaccharieramzi approved these changes

Assignees

@chaithyagr chaithyagr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaithyagr @sfarrens @zaccharieramzi