Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class for smoothness indicators #13

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Class for smoothness indicators #13

merged 3 commits into from
Feb 20, 2020

Conversation

vladotomov
Copy link
Member

@vladotomov vladotomov commented Feb 15, 2020

@HennesHajduk , please make sure that your smoothness indicators test still give the same numbers. The ones in the README look fine.

This just moves all the related code in a class SmoothnessIndicator.

Copy link
Collaborator

@HennesHajduk HennesHajduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FCTSolver class does not use the smoothness indicators (neither does the ClipScaleSolver class).
So the results for ./remhos -mt 4 are the same if you use smoothness indicators 0,1 and 2.
Please include them according to the currently unused routine ComputeFCTSolution.

I will then rerun the tests in our paper and see if I get the same results.
Thanks

Removed the old ComputeFCTSolution function as the ClipScaleSolver
is expected to work identically.
@vladotomov
Copy link
Member Author

@HennesHajduk I included the smoothness indicator calculations to the new FCT classes. Please check if it's correct.

@HennesHajduk
Copy link
Collaborator

I re-ran the following tests corresponding to our Computers & Fluids paper:
Fig. 2, d-f (Smoothness indicator 1 / formula (37))
Fig 3 c, f (Smoothness indicator 1 / formula (37))

The results are the identical.

Additionally I checked the same configurations with smoothness indicator 2 / formula (38), as well as Fig. 5 d-i, to which I don't have reference values.

The results seem fine, too.

@HennesHajduk HennesHajduk merged commit 55ddf47 into master Feb 20, 2020
@vladotomov vladotomov deleted the smth-ind-class branch February 20, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants