Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up backend headers for const and argument names #1202

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Clean up backend headers for const and argument names #1202

merged 2 commits into from
Apr 25, 2023

Conversation

jeremylt
Copy link
Member

Small consistency changes

@jeremylt jeremylt self-assigned this Apr 20, 2023
jrwrigh
jrwrigh approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@jrwrigh jrwrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, otherwise looks good.

backends/cuda-ref/ceed-cuda-ref.h Outdated Show resolved Hide resolved
backends/hip-ref/ceed-hip-ref.h Outdated Show resolved Hide resolved
@jeremylt jeremylt force-pushed the jeremy/const-fix branch 2 times, most recently from 8ae179c to 538bbb0 Compare April 25, 2023 15:50
@jeremylt jeremylt merged commit 30d6126 into main Apr 25, 2023
@jeremylt jeremylt deleted the jeremy/const-fix branch April 25, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiangrimberg sebastiangrimberg sebastiangrimberg left review comments

@jrwrigh jrwrigh jrwrigh approved these changes

Assignees

@jeremylt jeremylt

Labels
1-In Review minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremylt @jrwrigh @sebastiangrimberg