fluids: Stats don't overwrite solution on first-step failure #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When you have an initial condition from a previous problem, it might fail on the first step. This will cause `reason != TS_CONVERGED_ITERATING` and thus it will continue on with the rest of the TSMonitor routine. If you have a stats file from that initial condition, it will be overwritten. Regardless of the overwriting behavior, it *never* makes sense to write out a stats file on the first step; Using left-rectangle rule for the time averaging integration, the initial step should *never* be used, thus there is nothing to collect or write.
jedbrown
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have an initial condition from a previous problem, it might fail on the first step. This will cause
reason != TS_CONVERGED_ITERATINGand thus it will continue on with the rest of the TSMonitor routine. If you have a stats file from that initial condition, it will be overwritten.Regardless of the overwriting behavior, it never makes sense to write out a stats file on the first step; Using left-rectangle rule for the time averaging integration, the initial step should never be used, thus there is nothing to collect or write.