Fixed small bug in sgs_dd_train Q function #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug introduced in #1529. Whoops. |
- Fixed bug in sgs_dd_train QF, left over from debugging - SmartSim tests were previously not running at all, due to junit.py checking if `SMARTREDIS_DIR` was a file instead of a directory Co-authored-by: James Wright <james@jameswright.xyz>
|
Note there was also a bug in the testing framework that was actually preventing all SmartSim tests from running. This is now fixed. |
jrwrigh
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed small bug in sgs_dd_training q function that was setting the training data to values from 0 to 11.