Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The purpose of the "Domain" window in the Datasets panel #320

Open
dkang2 opened this issue Apr 3, 2023 · 8 comments
Open

The purpose of the "Domain" window in the Datasets panel #320

dkang2 opened this issue Apr 3, 2023 · 8 comments
Assignees
Labels

Comments

@dkang2
Copy link
Collaborator

dkang2 commented Apr 3, 2023

Is your feature request related to a problem? Please describe.
There are two press buttons in the "Domain" window on the "Datasets Panel": "Edit Me" and "Metadata Me". I'm not clear what these two buttons for? When I click on them, nothing happens. And when searching the Verdi Manual, nothing popping up either.

Describe the solution you'd like
Either add some functions to these buttons, or delete the window altogether? I guess that there must be some initial thinking to include this window. Or if these buttons are already associated with some functions, please describe it in the manual.

Describe alternatives you've considered
If no functions are associated at this time, maybe just remove the window.

Additional context
Add any other context or screenshots about the feature request here.
image

@dkang2
Copy link
Collaborator Author

dkang2 commented Apr 3, 2023

After further testing with other datasets, in fact that if click "Metadata Me", a window pops up to show the metadata of the dataset and it is nice. This feature should be kept, but the space under the buttons don't show anything. If it is the case, we may just keep the "Metadata Me" button.

image

@dkang2
Copy link
Collaborator Author

dkang2 commented Apr 3, 2023

The "Metadata Me" works with CMAQ/WRF netcdf formats, but it doesn't work with MPAS data format. It would be nice to implement this for MPAS data, too.

@yadongxuEPA
Copy link
Collaborator

Retested VERDI 2.1.4 20230831 builds on Atmos, found that this issue has not resolved. Actually the "Domain" GUI has disappeared (tested with loading a CMAQ dataset and a MPAS dataset).
issue_320_load_CMAQ_dataset
issue_320_load_MPAS_dataset

@dkang2
Copy link
Collaborator Author

dkang2 commented Sep 13, 2023

This VERDI 2.1.4 20230911 build has restored earlier features, but the issue hasn't been addressed.
image

@yadongxuEPA
Copy link
Collaborator

yadongxuEPA commented Sep 20, 2023

Retested VERDI 2.1.4 20230911 and 20230924 builds on Atmos, found that this issue has resolved. Now the "Domain" GUI has been removed from Datasets Tab.

@lizadams
Copy link
Contributor

Testing with VERDI_2.1.5_mac_20240124.tar.gz

I am confused, we say in the Release notes that the following has been done:

"Enable "Metadata Me" for MPAS (#320)"

But the Domain GUI has been removed, so this option is no longer supported.

@lizadams lizadams reopened this Jan 25, 2024
@yadongxuEPA
Copy link
Collaborator

Testing with VERDI_2.1.5_mac_20240124.tar.gz

I am confused, we say in the Release notes that the following has been done:

"Enable "Metadata Me" for MPAS (#320)"

But the Domain GUI has been removed, so this option is no longer supported.

Hi Liz,

Thanks for re-testing and double-checking the issues. That's a good catch for #320. I think that we changed the work scope for this issue. Initially we wanted to enable "Metadata Me" feature for MPAS, but later we decided to simply remove the "domain" window.
At this point, I think we definitely need to update the release note for VERDI 2.1.5. And keep this issue open if we still want to enable "Metadata Me' feature for MPAS in the future.

@lizadams
Copy link
Contributor

I've updated the Release Notes on the main branch to reflect this:

https://github.com/CEMPD/VERDI/blob/master/doc/Release_Notes/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants