Add core typings #59
Merged
Add core typings #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
reviewed
Dec 15, 2020
Co-authored-by: Paweł Srokosz <pawel.srokosz@cert.pl>
psrok1
reviewed
Dec 15, 2020
karton/core/inspect.py
Outdated
| def last_update(self) -> int: | ||
| return max(task.last_update for task in self.tasks) | ||
| def last_update(self) -> float: | ||
| return max(task.last_update for task in self.tasks if task.last_update) |
There was a problem hiding this comment.
I would make the last_update non-optional (e.g. initialize with time.time() on construction). If max gets the empty sequence, raises exception ValueError: max() arg is an empty sequence which might be not expected by user.
There was a problem hiding this comment.
Corrected, although it still could raise that exception if self.tasks is empty
psrok1
added a commit
that referenced
this pull request
Dec 18, 2020
* Add core typings * Sort imports * Format code with black * Reformat with correct black * Fix circular import * Make flake happy * Make mypy happy * Update karton/core/backend.py Co-authored-by: Paweł Srokosz <pawel.srokosz@cert.pl> * Refactor content in ResourceBase constructor * Reformat * Make task.last_update no-noptional * Split long lines * More exceptions * Reformat * Add system typings * Check downloaded task Co-authored-by: Paweł Srokosz <pawel.srokosz@cert.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
Closes #60