Add partial regex string support #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-code
reviewed
May 14, 2020
msm-code
suggested changes
May 14, 2020
msm-code
approved these changes
May 14, 2020
KWMORALE
pushed a commit
to KWMORALE/mquery
that referenced
this pull request
Jul 29, 2020
* Add partial regex strings support * Get or expressions * run black * Make mypy happy * Update tests * Fix unit tests * Add missing argument * Add more test yaras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
Regex strings are ignored when converting yara rules to ursa queries
What is the new behaviour?
Some regex strings should be correctly converted to ursa expressions
Test plan
run
lib/yaraparse.pyon yara files that do and don't contain regex stringsClosing issues
fixes #97