Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Human impact change proposal #476

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Human impact change proposal #476

merged 3 commits into from
Feb 19, 2024

Conversation

sei-bkoo
Copy link
Contributor

Looking at the limited discussion from the ticket, just made a few changes:

  • Moved the comment about "we changed this from a previous version" as a footnote in regards to how this is a compound decision to make it less confusing for people who don't know the history of SSVC
  • Then just moved up the description that I thought was helpful to be a part of the introduction up.

Not sure if there's anything else content wise that we want added, but this cleans it up a bit at least. Let me know if there's anything specific to be added!

@sei-bkoo
Update human_impact.md
9fed68f 
updated human_impact.md
@sei-bkoo
Update human_impact.md
c435c9a 
updated human_impact.md (v2)
@sei-bkoo sei-bkoo self-assigned this Feb 16, 2024
@ahouseholder ahouseholder linked an issue Feb 19, 2024 that may be closed by this pull request
Update description of Human Impact #292
Closed
ahouseholder
ahouseholder approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Thanks!

@ahouseholder ahouseholder added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 19, 2024
@ahouseholder ahouseholder added this to the SSVC 202403 milestone Feb 19, 2024
@ahouseholder ahouseholder merged commit 57df11e into CERTCC:main Feb 19, 2024
2 checks passed
@sei-bkoo sei-bkoo deleted the HumanImpact_ChangeProposal branch February 20, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahouseholder ahouseholder ahouseholder approved these changes

@cgyarbrough cgyarbrough Awaiting requested review from cgyarbrough cgyarbrough is a code owner

@sei-vsarvepalli sei-vsarvepalli Awaiting requested review from sei-vsarvepalli sei-vsarvepalli is a code owner

@j--- j--- Awaiting requested review from j--- j--- is a code owner

Assignees

@sei-bkoo sei-bkoo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.

Update description of Human Impact
2 participants
@sei-bkoo @ahouseholder