Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dpdk: resolve issues #117, #118, #122, #125 #129

Merged
merged 5 commits into from
Dec 21, 2022
Merged

dpdk: resolve issues #117, #118, #122, #125 #129

merged 5 commits into from
Dec 21, 2022

Conversation

cejkato2
Copy link
Contributor

No description provided.

@cejkato2
Copy link
Contributor Author

EAL parameters issue regarding CPU affinity was mentioned in #118.

@SiskaPavel
Copy link
Contributor

SiskaPavel commented Dec 21, 2022 •
edited
Loading

This PR resolves #117, #118, #122, #125

@SiskaPavel SiskaPavel marked this pull request as ready for review December 21, 2022 14:44
@SiskaPavel SiskaPavel changed the title dpdk: check empty EAL parameters, removed lcore thread affinity dpdk: fix issues #117, #118, #122, #125 Dec 21, 2022
@SiskaPavel SiskaPavel changed the title dpdk: fix issues #117, #118, #122, #125 dpdk: resolve issues #117, #118, #122, #125 Dec 21, 2022
@cejkato2
Copy link
Contributor Author

The changes are ok - argv[0] solves the problem with skipped eal;
the removed affinity setting leaves the setup up to DPDK (which works correctly);
according to offline discussion, double increased packet count affected indexing.

@SiskaPavel SiskaPavel merged commit 543d41c into master Dec 21, 2022
@SiskaPavel SiskaPavel deleted the dpdk-update branch December 21, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiskaPavel SiskaPavel SiskaPavel approved these changes

Assignees

@cejkato2 cejkato2

@hynekkar hynekkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cejkato2 @SiskaPavel @hynekkar