fix: correctly detect expired cert (vs CA) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenSSL certificate chain dump, depth=0 corresponds to the leaf (end-entity) certificate (not root CA). rad_eap_test was incorrectly reporting `CA certificate expired` for an expired leaf certificate. Fix the logic by: * renaming the `depth=0` pattern from `root_certificate` to `leaf_certificate` * swapping around whether the pattern should match (certificate) vs should not match (CA certificate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL certificate chain dump, depth=0 corresponds to the leaf (end-entity) certificate (not root CA).
rad_eap_test was incorrectly reporting
CA certificate expiredfor an expired leaf certificate.Fix the logic by:
depth=0pattern fromroot_certificatetoleaf_certificate