Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify splines names #382

Merged
merged 14 commits into from
Apr 19, 2024
Merged

Clarify splines names #382

merged 14 commits into from
Apr 19, 2024

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Apr 2, 2024 •
edited
Loading

Aims to resolve the first dash of #231

sed -i "s/derivs_domain_type/batched_derivs_domain_type/g" *pp

sed -i "s/vals_domain/batched_interpolation_domain/g" *pp
sed -i "s/spline_domain/batched_spline_domain/g" *pp
sed -i "s/spline_tr_domain/batched_spline_tr_domain/g" *pp
sed -i "s/derivs_xmin_domain/batched_derivs_xmin_domain/g" *pp
sed -i "s/derivs_xmax_domain/batched_derivs_xmax_domain/g" *pp
sed -i "s/bsplines_domain/spline_domain/g" *pp

@blegouix blegouix self-assigned this Apr 2, 2024
@blegouix blegouix marked this pull request as draft April 2, 2024 18:03
@blegouix blegouix requested a review from tpadioleau April 3, 2024 10:31
@blegouix blegouix marked this pull request as ready for review April 3, 2024 10:31
@blegouix
Copy link
Collaborator Author

@tpadioleau do you think we can merge this soon ?

@tpadioleau
Copy link
Member

@tpadioleau do you think we can merge this soon ?

Can you check again the transformation for sed -i "s/bsplines_domain_type/spline_domain_type/g" *pp, I think you applied it before sed -i "s/spline_domain_type/batched_spline_domain_type/g" *pp, I don't see the type spline_domain_type anymore in the code.

@blegouix
Copy link
Collaborator Author

Yes sorry I forgot to review myself before asking you, if the CI passes it should be fine now

@tpadioleau
Copy link
Member

Aims to resolve the first dash of #231

sed -i "s/vals_domain_type/batched_interpolation_domain_type/g" *pp
sed -i "s/spline_tr_domain_type/batched_spline_tr_domain_type/g" *pp
sed -i "s/derivs_domain_type/batched_derivs_domain_type/g" *pp
sed -i "s/bsplines_domain_type/spline_domain_type/g" *pp

sed -i "s/vals_domain/batched_interpolation_domain/g" *pp
sed -i "s/spline_domain/batched_spline_domain/g" *pp
sed -i "s/bsplines_domain/spline_domain/g" *pp

Did you remove the transformation sed -i "s/spline_domain_type/batched_spline_domain_type/g" *pp ?

@blegouix
Copy link
Collaborator Author

blegouix commented Apr 16, 2024 •
edited
Loading

Yes because this is covered by:

sed -i "s/spline_domain/batched_spline_domain/g" *pp

So the change is effective

EDIT: actually this is the same for vals_domain & bsplines_domain. I edit the description

@blegouix blegouix marked this pull request as draft April 16, 2024 13:38
@blegouix
Copy link
Collaborator Author

I put it in draft again because this part is not consistent:

batched_spline_domain_type batched_spline_domain() const noexcept

batched_spline_tr_domain_type spline_tr_domain() const noexcept

@blegouix blegouix marked this pull request as ready for review April 17, 2024 07:57
@tpadioleau tpadioleau merged commit 9281e03 into main Apr 19, 2024
0 of 3 checks passed
@tpadioleau tpadioleau deleted the clarify-spline-names branch April 19, 2024 07:46
jbigot pushed a commit to gyselax/gyselalibxx that referenced this pull request Jul 11, 2024
@EmilyBourne
ddc sync
0f1e374 
* Splines LAPACK backend
* `ddc::parallel_for_each` now can take a label! Usefull for profiling.
* Align `UniformBSplines` API to `NonUniformBSplines` API
* Change terminology in splines (ie. `spline_domain` -\> `batched_spline_domain`... complete list: CExA-project/ddc#382)
* Ginkgo throws error in case of non-convergency.
* Bsplines API is based on `mdspan` in place of `std::array`.
* Deprecate `nbe_xmin` and `nbe_xmax` in splines (it is redundant with `nbc_xmin`and `nbc_xmax` for all boundary conditions except NATURAL which has been removed because unused).
* Update supposedly-ddc-internal SplinesLinearProblem API (which is used by quadrature).
* Lot of minor internal changes.

See merge request gysela-developpers/gyselalibxx!548

--------------------------------------------

Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
Geoflow pushed a commit to gyselax/gyselalibxx that referenced this pull request Aug 5, 2024
@EmilyBourne
ddc sync
4697724 
* Splines LAPACK backend
* `ddc::parallel_for_each` now can take a label! Usefull for profiling.
* Align `UniformBSplines` API to `NonUniformBSplines` API
* Change terminology in splines (ie. `spline_domain` -\> `batched_spline_domain`... complete list: CExA-project/ddc#382)
* Ginkgo throws error in case of non-convergency.
* Bsplines API is based on `mdspan` in place of `std::array`.
* Deprecate `nbe_xmin` and `nbe_xmax` in splines (it is redundant with `nbc_xmin`and `nbc_xmax` for all boundary conditions except NATURAL which has been removed because unused).
* Update supposedly-ddc-internal SplinesLinearProblem API (which is used by quadrature).
* Lot of minor internal changes.

See merge request gysela-developpers/gyselalibxx!548

--------------------------------------------

Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
EmilyBourne added a commit to gyselax/gyselalibxx that referenced this pull request Oct 10, 2024
@EmilyBourne
ddc sync
d246db0 
* Splines LAPACK backend
* `ddc::parallel_for_each` now can take a label! Usefull for profiling.
* Align `UniformBSplines` API to `NonUniformBSplines` API
* Change terminology in splines (ie. `spline_domain` -\> `batched_spline_domain`... complete list: CExA-project/ddc#382)
* Ginkgo throws error in case of non-convergency.
* Bsplines API is based on `mdspan` in place of `std::array`.
* Deprecate `nbe_xmin` and `nbe_xmax` in splines (it is redundant with `nbc_xmin`and `nbc_xmax` for all boundary conditions except NATURAL which has been removed because unused).
* Update supposedly-ddc-internal SplinesLinearProblem API (which is used by quadrature).
* Lot of minor internal changes.

See merge request gysela-developpers/gyselalibxx!548

--------------------------------------------

Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
EmilyBourne added a commit to gyselax/gyselalibxx that referenced this pull request Oct 11, 2024
@blegouix @EmilyBourne
ddc sync
ddfdd5e 
* Splines LAPACK backend
* `ddc::parallel_for_each` now can take a label! Usefull for profiling.
* Align `UniformBSplines` API to `NonUniformBSplines` API
* Change terminology in splines (ie. `spline_domain` -\> `batched_spline_domain`... complete list: CExA-project/ddc#382)
* Ginkgo throws error in case of non-convergency.
* Bsplines API is based on `mdspan` in place of `std::array`.
* Deprecate `nbe_xmin` and `nbe_xmax` in splines (it is redundant with `nbc_xmin`and `nbc_xmax` for all boundary conditions except NATURAL which has been removed because unused).
* Update supposedly-ddc-internal SplinesLinearProblem API (which is used by quadrature).
* Lot of minor internal changes.

See merge request gysela-developpers/gyselalibxx!548

--------------------------------------------

Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau Awaiting requested review from tpadioleau

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegouix @tpadioleau