Use CI test script for off-line tests. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alejandrobodas Thanks for doing this. Just one comment - "cosp2_test_01" is sort of an obscure name for the testing script. "compare_to_reference?" We'd be better off, I think, being a bit more clear. |
|
PS "compare_to_reference" is a name I use but it's a very mild suggestion, if you have another name you like better . |
|
@alejandrobodas Thanks a lot, this seems perfect. I encourage you to merge onto master and close #43 |
|
@RobertPincus Thanks for the quick review. |
dustinswales
pushed a commit
that referenced
this pull request
Jun 3, 2020
Use CI test script for off-line tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CI tests and the off-line tests use different python scripts. This request simplifies the approach by changing the off-line tests instructions so that they use the script cosp2_test_01.py, use by the CI tests. This only involves changing the instructions and removing the old script and reference files. It also modifies cosp2_test_01.py to make the error/success messages colour-coded. This pull request addresses issue #43.